Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvcc: reduce log. #2550

Merged
merged 3 commits into from Dec 7, 2017
Merged

mvcc: reduce log. #2550

merged 3 commits into from Dec 7, 2017

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Dec 5, 2017

Fix #2507.

siddontang
siddontang reviewed Dec 5, 2017
View reviewed changes
src/storage/mvcc/txn.rs Outdated
"duplicated prewrite with start_ts {}, ignore it.",
self.start_ts
);
MVCC_DUPLICATE_PREWRITE_COUNTER.inc();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to handle other duplicated logs?

@siddontang
Copy link
Contributor

Do we need to handle https://github.com/disksing/tikv/blob/07968dd682eccc93e8c26433c02758f397085c72/src/storage/mvcc/txn.rs#L196 and https://github.com/disksing/tikv/blob/07968dd682eccc93e8c26433c02758f397085c72/src/storage/mvcc/txn.rs#L251 too?

Maybe we need to record the message once?

@disksing
Copy link
Contributor Author

disksing commented Dec 6, 2017

No. They are conflicts and have other metrics cover them.

I was not able to find a good way to log only once for each txn, so turn to use metrics instead...

@siddontang
Copy link
Contributor

do we need to use debug level for 196 and 251 too?

@disksing
Copy link
Contributor Author

disksing commented Dec 6, 2017

I think INFO is ok.

@siddontang
Copy link
Contributor

LGTM

PTAL @AndreMouche

zhangjinpeng87
zhangjinpeng87 approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjinpeng87 zhangjinpeng87 merged commit 6b4f7db into tikv:master Dec 7, 2017
@disksing disksing deleted the reduce-log branch December 7, 2017 04:35
BusyJay pushed a commit to BusyJay/tikv that referenced this pull request Dec 11, 2017
@disksing @BusyJay
mvcc: reduce log. (tikv#2550)
129f981
BusyJay added a commit that referenced this pull request Dec 11, 2017
@BusyJay
Prepare 1.0.4 (#2571)
da2efff 
* endpoint: reduce slow log (#2523)
* mvcc: reduce log. (#2550)
* scheduler: reduce slow log. (#2525)
* mysql/decimal: fix bug in decode (#2547)
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
@disksing @zhangjinpeng87
mvcc: reduce log. (tikv#2550)
2cf7d98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang left review comments

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@disksing @siddontang @zhangjinpeng87