tikv-ctl: add bad-regions subcommand.
#2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you give me some examples, like damaging some region metas and using our tool? |
|
I have add some test cases to show how the command check bad regions. PTAL thanks. |
…v-ctl-bad-regions
overvenus
reviewed
Dec 29, 2017
src/bin/tikv-ctl.rs
Outdated
| @@ -490,6 +492,10 @@ impl DebugExecutor for DebugClient { | |||
| fn set_region_tombstone(&self, _: u64, _: Region) { | |||
| unimplemented!(); | |||
| } | |||
|
|
|||
| fn print_bad_regions(&self) { | |||
| panic!("only avaliable for local mode"); | |||
|
Great work |
|
@overvenus PTAL again, thanks. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2612
Now the command can check all regions which have corrupted
last index,commited indexorapplied index. But it can't handle bad snapshot until now.