New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable portable on MacOS #2696
Conversation
Any harm doing this? |
|
LGTM |
Makefile
Outdated
@@ -1,5 +1,10 @@ | |||
ENABLE_FEATURES ?= default | |||
|
|||
# Disable portable on MacOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why should we need to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
I thought you need to enable portable when compiling on macOS. |
@BusyJay |
Rest LGTM |
Disable portable on MacOS to sidestep the compiler bug in clang 4.9.