Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated text in tidb-stable-zh-manual.pdf #186

Closed
qiancai opened this issue Nov 25, 2021 · 11 comments · Fixed by pingcap/docs-cn#16173
Closed

Truncated text in tidb-stable-zh-manual.pdf #186

qiancai opened this issue Nov 25, 2021 · 11 comments · Fixed by pingcap/docs-cn#16173
Assignees
Labels
2024-tidb-docs-dash tidb-docs-dash-bonus Indicates that the issue or PR with bonus points

Comments

@qiancai
Copy link
Collaborator

qiancai commented Nov 25, 2021

Describe the bug
For all tables in https://download.pingcap.org/tidb-stable-zh-manual.pdf, the alignment is center and the columns are too narrow to show the full text. As a reader, I could not even see the full text to understand the document.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://download.pingcap.org/tidb-stable-zh-manual.pdf.
  2. From the left TOC panel, click 部署标准集群 > 规划集群拓扑 > 混合部署拓扑.
  3. Check the table under 拓扑信息.
    image

Expected behavior

  • The tables in tidb-stable-zh-manual.pdf should be left-aligned.
  • The width of the table should fit the page.
  • If a cell contains long text, the cell should wrap the text instead of truncating it.
@curiousRay
Copy link

/assign

@curiousRay
Copy link

@qiancai Didn't get assigned immediately after I commented /assign

@qiancai
Copy link
Collaborator Author

qiancai commented Dec 29, 2023

@curiousRay Sorry for the late response. I've assigned this issue to you manually.

@qiancai qiancai added the tidb-docs-dash-bonus Indicates that the issue or PR with bonus points label Dec 29, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented Dec 29, 2023

Hi @curiousRay Thanks for taking this issue. 👍

Just would like to let you know that the source code of the doc PDF template is located in https://github.com/pingcap/docs-cn/blob/master/templates/template.tex. Hence, to update the source code, please create a pull request in pingcap/doc-cn.

@qiancai
Copy link
Collaborator Author

qiancai commented Dec 29, 2023

And if you need to test the PDF generation, please use the script at pingcap/docs-cn.

@qiancai
Copy link
Collaborator Author

qiancai commented Jan 7, 2024

Hi @curiousRay, we have provided a tutorial for self-service PDF generation. Please check 自助生成 TiDB 文档 PDF 教程 for more information.

@curiousRay
Copy link

@qiancai Get it!

@dveeden
Copy link

dveeden commented Jan 9, 2024

I think this might be the same issue: pingcap/docs#15982

For other PDF related issues see https://github.com/pingcap/docs/issues?q=is%3Aopen+is%3Aissue+in%3Atitle+PDF

@dveeden
Copy link

dveeden commented Jan 9, 2024

Maybe switching to another image like https://hub.docker.com/r/pandoc/extra would be good.

@rpaik
Copy link
Member

rpaik commented Jan 10, 2024

👋 @curiousRay, just a friendly reminder to submit your PR for TiDB Docs Dash by January 12 at 07:59 UTC. 🙏

Please reach out if you have any questions or need any help.

@curiousRay
Copy link

curiousRay commented Jan 12, 2024

Raised a PR (pingcap/docs-cn#16173) in the pingcap/docs-cn repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash tidb-docs-dash-bonus Indicates that the issue or PR with bonus points
Development

Successfully merging a pull request may close this issue.

5 participants