-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing alt text #463
Comments
Hi @rpaik! :) I raised the issue per your suggestion! :) |
@CBID2 pingcap/docs#4389 might also be somewhat related. This would replace images with ebnf text that than gets rendered. See https://github.com/pingcap/docs/pull/16050/files for an example. |
This is https://wave.webaim.org/ right? |
Thanks for pointing this out @dveeden! :) So...does this mean I should not do a PR for this one? |
No what I was trying to say is that fixing this issue and the issue I mentioned both help with improving accessibility. Both are needed. The ebnf diagrams are only replacing a small portion of the total set of images. |
Ohh thanks for clarifying @dveeden! :) |
/assign |
@CBID2 Thanks a lot for reporting this issue. I found there's no problem with images in markdown. The problem occurs on those image component written in JSX.
So we need to add an |
Sure @Yuiham! :) Can you also put the 2024-tidb-docs-dash label on my PR too? For some odd reason, it got removed. |
@CBID2 Done😀 |
Describe the bug
I did an accessibility test on the website, and the results showed that most of the images/icons were missing alt text. Without them, the content of an image will not be available to screen reader users or when the image is unavailable. This can cause these users to have a harder time navigating the site.
To Reproduce
N/A
Expected behavior
N/A
Screenshots
![screenshot of accessibility issue](https://private-user-images.githubusercontent.com/105683440/295787963-fd1711f7-46d8-48be-b60f-254d262ef1f0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNzk3NTYsIm5iZiI6MTcyMTM3OTQ1NiwicGF0aCI6Ii8xMDU2ODM0NDAvMjk1Nzg3OTYzLWZkMTcxMWY3LTQ2ZDgtNDhiZS1iNjBmLTI1NGQyNjJlZjFmMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOVQwODU3MzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MDFjNjQ5NDYyZmZkYjdmZTY4OTkxNWI0ZmEzYTA3ZThmY2MxNTQxM2RkYTExMjFjMzdjMjM3MTc1MDZiMzdlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.gRoeBRTAs-c1lSkVJt0QLwEjVdEbo3GWFqxVGtQSIiA)
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: