Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrepl clj eval with multiple responses #118

Closed
awb99 opened this issue Apr 2, 2020 · 1 comment
Closed

nrepl clj eval with multiple responses #118

awb99 opened this issue Apr 2, 2020 · 1 comment

Comments

@awb99
Copy link
Contributor

awb99 commented Apr 2, 2020

When evaling a segment with multiple expressions, nrepl sends back multiple values.
For this reason, in the notebook, we should display multiple values, and not just one
output value.

This is the server log from an eval that returns first nil, then ()

20-04-02 03:24:31 lggram DEBUG [pinkgorilla.kernel.jetty9-ws-relay:95] - ws Rcvd Text   {:op "eval", :code "; SETUP / TEST ALPHA VANTAGE FEED\n\n; secrets should not be saved in a notebook\n;\n; secret loads a key from user defined secrets.\n; the current implementation does just read the file test/creds.edn\n; in the future the notebook will save creds only in webbrowser local storage\n\n(set-key! (secret :alphavantage))\n;(clojure.pprint/print-table (take 5 (reverse (get-daily :compact \"FNARX\"))))\n(get-daily :compact \"BONGO1\")", :id "2acf3d88-7fd4-42e0-83bb-a86d1a6b721b", :session "a791102a-6df8-40fd-9b24-73a5365ba6c4"}
20-04-02 03:24:31 lggram INFO [pinkgorilla.kernel.jetty9-ws-relay:53] - ws Send  {:id "2acf3d88-7fd4-42e0-83bb-a86d1a6b721b", :session "a791102a-6df8-40fd-9b24-73a5365ba6c4", :ns "dynalloc", :value "\"{:value-response {:type :html, :content [:span {:class \\\"clj-nil\\\"} \\\"nil\\\"], :value \\\"nil\\\"}}\""}
20-04-02 03:24:33 lggram INFO [pinkgorilla.kernel.jetty9-ws-relay:53] - ws Send  {:id "2acf3d88-7fd4-42e0-83bb-a86d1a6b721b", :session "a791102a-6df8-40fd-9b24-73a5365ba6c4", :ns "dynalloc", :value "\"{:value-response {:type :list-like, :open [:span {:class \\\"clj-list\\\"} \\\"(\\\"], :close [:span {:class \\\"clj-list\\\"} \\\")\\\"], :separator [:span \\\" \\\"], :items (), :value \\\"()\\\"}}\""}
20-04-02 03:24:33 lggram INFO [pinkgorilla.kernel.jetty9-ws-relay:53] - ws Send  {:id "2acf3d88-7fd4-42e0-83bb-a86d1a6b721b", :session "a791102a-6df8-40fd-9b24-73a5365ba6c4", :status #{:done}}
@awb99
Copy link
Contributor Author

awb99 commented Jun 29, 2020

fixed in picasso and notebook-ui

@awb99 awb99 closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant