Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review my app #2

Open
pinkyandthebrain opened this issue Aug 26, 2013 · 2 comments
Open

Review my app #2

pinkyandthebrain opened this issue Aug 26, 2013 · 2 comments

Comments

@pinkyandthebrain
Copy link
Owner

/cc @nesquena @timothy1ee

The scrolling is not smooth yet but early feedback is appreciated. Thanks!

@timothy1ee
Copy link

Great, looks good. I wonder if - (void) scrollViewWillBeginDecelerating:(UIScrollView *)scrollView is contributing to the slowness. You're calling [self fetchData] twice for some reason, and triggering a network request every time the scroll view decelerates might be too aggressive.

To make it more conservative, keep the code in the same method, but check against contentOffset and only trigger a load if you're near the bottom of the feed. You can also maintain a loading state, and have fetchData do nothing if there's already a load in progress.

@pinkyandthebrain
Copy link
Owner Author

Thanks for your feedback. I was experimenting with prefetching two pages of data and checked in the code to call fetchdata twice. My initial stab at implementing conservative fetch is tracked by Issue #3 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants