Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application's shutdown sometimes fails (async tasks) #27

Closed
1 of 2 tasks
pinnaculum opened this issue Aug 3, 2020 · 1 comment
Closed
1 of 2 tasks

Application's shutdown sometimes fails (async tasks) #27

pinnaculum opened this issue Aug 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@pinnaculum
Copy link
Owner

Software version

0.4.31

OS

Any

IPFS daemon type (standalone/custom)

  • Standalone
  • Custom IPFS daemon

Expected Behavior

Exiting the browser should work reliably no matter what

Current Behavior

The coroutine responsible for shutting down the application sometimes
fails on first attempt (although it works on next attempts in that case), leaving
the app/UI still running.

Steps to Reproduce

  1. Start the browser
  2. Perform any tasks ..
  3. From the main menu select 'Quit' or hit ctrl+q

Possible Solution

Using aiomonitor it's possible to see which tasks are still running after the app exit failed.

Extra information

The coroutine that performs the shutdown could be the main issue. The order in which the tasks are closed of course matters. The shutdown of the aiojobs scheduler seems to work pretty well.

@pinnaculum pinnaculum added the help wanted Extra attention is needed label Aug 3, 2020
@pinnaculum
Copy link
Owner Author

Help much appreciated from python devs who have some experience with asyncio and have an idea about how to tackle this issue

@pinnaculum pinnaculum pinned this issue Aug 4, 2020
@pinnaculum pinnaculum added the bug Something isn't working label Aug 4, 2020
@pinnaculum pinnaculum removed the help wanted Extra attention is needed label Feb 16, 2021
@pinnaculum pinnaculum unpinned this issue Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant