Skip to content

Commit

Permalink
Removed server.app.logger
Browse files Browse the repository at this point in the history
Fixes #22.
  • Loading branch information
mcollina committed Sep 7, 2017
1 parent bc7df9f commit 3b4605e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 16 deletions.
5 changes: 1 addition & 4 deletions README.md
Expand Up @@ -50,10 +50,7 @@ server.register(require('hapi-pino'), (err) => {
process.exit(1)
}

// the logger is available in server.app
server.app.logger.warn('Pino is registered')

// also as a decorated API
// The logger is available as a decorated API
server.logger().info('another way for accessing it')

// and through Hapi standard logging system
Expand Down
3 changes: 0 additions & 3 deletions index.js
Expand Up @@ -48,9 +48,6 @@ function register (server, options, next) {

const mergeHapiLogData = options.mergeHapiLogData

// expose logger as 'server.app.logger'
server.app.logger = logger

// expose logger as 'server.logger()'
server.decorate('server', 'logger', () => logger)

Expand Down
16 changes: 7 additions & 9 deletions test.js
Expand Up @@ -81,14 +81,12 @@ function ltest (func) {
})
}

experiment('logs through the server.app.logger', () => {
ltest((level, done) => {
const server = getServer()
registerWithSink(server, level, onHelloWorld, (err) => {
expect(err).to.be.undefined()
server.app.logger[level]('hello world')
done()
})
test('server.app.logger is undefined', (done) => {
const server = getServer()
registerWithSink(server, 'info', () => done(new Error('fail')), (err) => {
expect(err).to.be.undefined()
expect(server.app.logger).to.be.undefined()
done()
})
})

Expand Down Expand Up @@ -566,7 +564,7 @@ experiment('uses a prior pino instance', () => {

server.register(plugin, (err) => {
expect(err).to.be.undefined()
server.app.logger.info({foo: 'bar'}, 'hello world')
server.logger().info({foo: 'bar'}, 'hello world')
})
})
})
Expand Down

0 comments on commit 3b4605e

Please sign in to comment.