Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If msg is a number its removed from output #181

Closed
e3tegi opened this issue May 3, 2021 · 2 comments
Closed

If msg is a number its removed from output #181

e3tegi opened this issue May 3, 2021 · 2 comments

Comments

@e3tegi
Copy link

e3tegi commented May 3, 2021

pino-pretty/lib/utils.js

Line 226 in d9fc678

if (typeof log[messageKey] !== 'string') return undefined

Why delete the msg if its a number?
@mcollina
Copy link
Member

mcollina commented May 3, 2021

Would you like to send a Pull Request to add the support for it? Remember to add unit tests.

@e3tegi e3tegi mentioned this issue May 3, 2021
Closed
@LRipi LRipi mentioned this issue Feb 15, 2022
Closed
@10xLaCroixDrinker
Copy link
Contributor

This was fixed in #434

@mcollina mcollina closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @10xLaCroixDrinker @e3tegi