-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should formatters and timestamp be done with transport? #1213
Comments
I don't understand the question :(. Can you clarify? Is the doc not covering this well enough? What is missing? the sample code looks ok.
What situation?
No it is not, you need to set it up. |
Maybe a little different example than the OP, but for my usage, the replacement of prettyPrint option with the pretty-print as a transport is a problem. I have not yet figured out how I can modify the transport on an instance. What we used to do was be able to set or clear the prettyPrint option to dynamically flip that formatting, for various reasons. Is there a "handle" to the transport, such that I can modify it, enable/disable that transport, or replace by setting a new transport instance on the same logger instance? |
You can just use prettyPrint as a stream: https://github.com/pinojs/pino-pretty#programmatic-integration |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi,
When reading documentation, it's stated that reformatting should be done using transports for taking the benefit of workerThreads for performance reasons.
As stated:
So my question from it like: How should we handle simple formats to level and timestamp for example?
Here's a sample code:
If so, how one should handle such situation here?
Additionally, is pino using worker threads underneath by default when doing simple logging?
#1182
The text was updated successfully, but these errors were encountered: