Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named export not available for browser.js #1792

Closed
marcoreni opened this issue Aug 30, 2023 · 2 comments · Fixed by #1803
Closed

Named export not available for browser.js #1792

marcoreni opened this issue Aug 30, 2023 · 2 comments · Fixed by #1803

Comments

@marcoreni
Copy link

It seems there's something wrong with the typings and the browser file.

1- Types are declared in pino.d.ts
2- Inside types, we have both a default and a named export for pino, so we should be able to do import pino from "pino" and import { pino } from "pino".
3- package.json specifies "browser": "./browser.js", and "main": "pino.js",
4- In pino.js, everything is exported correctly
5- In browser.js we only have the basic export. This means that import { pino } from "pino" does not work.

@jsumners
Copy link
Member

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants