Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child loggers do not support .child() #19

Closed
jsumners opened this issue Mar 31, 2016 · 5 comments · Fixed by #21
Closed

Child loggers do not support .child() #19

jsumners opened this issue Mar 31, 2016 · 5 comments · Fixed by #21

Comments

@jsumners
Copy link
Member

In bunyan, loggers created from logger.child() also have a .child() method. It'd be nice to support this so that pino is mostly a drop-in replacement for bunyan.

@mcollina
Copy link
Member

I thought almost no-one was creating child loggers of child loggers. What's your usecase?
Pino is heavily optimized, so we need to balance features with speed.

@jsumners
Copy link
Member Author

Application I'm writing is modular. When it loads a module it passes in a child logger. Said module may decide to create it's own child logger from that one in order to provide further specificity.

@davidmarkclements
Copy link
Member

@jsumners - it's a coming :bowtie:

@jsumners
Copy link
Member Author

jsumners commented Apr 1, 2016

@davidmarkclements awesome. Thank you.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants