Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing thoughts #23

Closed
btd opened this issue Apr 1, 2016 · 2 comments
Closed

Sharing thoughts #23

btd opened this issue Apr 1, 2016 · 2 comments

Comments

@btd
Copy link

btd commented Apr 1, 2016

Hi, guys. I noticed you also write logger. I also spend some time one this 1 and 2. Of course both much faster bunyan, intel and others. I did not compared to this project actually.

Right idea i got to improve speed - message compilation. So just compile string message to function producing simple string or json string - and you will gain huge speed improvement.

@davidmarkclements
Copy link
Member

hey @btd we actually started creating functions from strings, in 294ea42 we moved away from that since eval / new Function tends to scare people away, and if no one's going to use it, what's the point.

Even at that I recently attempted the same thing again (this time using new Function), just to see if we could squeeze any more performance out, and the results are negligible. Essentially, we're optimized to the point where we're on par to the building functions from strings approach, without having to frighten folk with eval.

Having said that, if you want to give your suggestion a go with pino it'd be awesome if you could prove me wrong (say if you can get another 20% that's worth creating a pino fork "pino-renegade" for people who don't mind their loggers using eval).

Closing for now, but let me know your plans, and thanks for sharing those othe loggers!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants