Mobile Safari - issues with globalThis Polyfill

[craigtaub]

We updated to the latest release today (as of today 5.12.4). We immediately started receiving "undefined is not an object (evaluating 'this.globalThis=this')" for anyone using the site on Mobile Safari.
We have reverted to a previous release.

We are using webpack and do not have any other Polyfill for globalThis.

Is there anyone who would be able to look at this?

[davidmarkclements]

this polyfill is here https://github.com/pinojs/pino/blob/master/browser.js#L309-L319

can you try replacing the polyfill with this and seeing if it works?

function polyfillGlobalThis () {
  if (typeof globalThis !== 'undefined') return globalThis
  Object.defineProperty(Object.prototype, 'globalThis', {
    get: function () {
      const g = (this.globalThis = this)
      delete Object.prototype.globalThis
      return g
    },
    configurable: true
  })
  return globalThis
}

[davidmarkclements]

and if that doesn't work can you see if this does:

function polyfillGlobalThis () {

  (function() {
    if (typeof globalThis === 'object') return
    Object.defineProperty(Object.prototype, '__magic__', {
      get: function() {
        return this
      },
      configurable: true
    })
    __magic__.globalThis = __magic__
    delete Object.prototype.__magic__
  }())

  return globalThis

}

[davidmarkclements]

based on the error they probably won't work - so a fix is in #653

but let me know if they do and we can simplify

[craigtaub]

Havn't been able to replicate it yet. Really appreciate the quick turnaround.

[davidmarkclements]

👍 5.12.5 released

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.