Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: broken pino options link #689

Closed
michal-sankot opened this issue Aug 1, 2019 · 7 comments
Closed

Documentation: broken pino options link #689

michal-sankot opened this issue Aug 1, 2019 · 7 comments

Comments

@michal-sankot
Copy link

Link to logger options in Pino with Fastify section points to 404 page not found page.

https://getpino.io/#/docs/web?id=fastify

In this line of text:
The logger option can also be set to an object, which will be passed through directly as the pino *options object*.

@mcollina
Copy link
Member

mcollina commented Aug 1, 2019

Would you like to send a PR to fix this?

@pwillcode
Copy link
Contributor

There is also a broken link on the page:
https://getpino.io/#/docs/redaction
which points to "https://getpino.io/#/api?id=pino" but probably intends to hit "https://getpino.io/#/docs/api?id=redact-array-object"

@mcollina
Copy link
Member

mcollina commented Feb 5, 2020 via email

@pwillcode
Copy link
Contributor

sure
#769

@AleksandrSl
Copy link
Contributor

Isn't this fixed already?

@mcollina
Copy link
Member

Yes, good catch!

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants