Error serializer only works on sub err object

[YouriT]

I'm unsure to understand why the err serializer option only works with an err key and not with all passed errors.

I would expect logger.info(ReferenceError('test')) to also use the optional serializer passed to pino just like logger.info({ err: ReferenceError('test') }) does.

Hence I would expect this test to pass:

const stream = sink()
const parent = pino({
  serializers: {
    err: (e) => ({
      t: e.constructor.name,
      m: e.message,
      s: e.stack
    })
  }
}, stream)

parent.info(ReferenceError('test'))
const o = await once(stream, 'data')
is(typeof o, 'object')
is(o.t, 'ReferenceError')
is(o.m, 'test')
is(typeof o.s, 'string')

But unfortunately it doesn't. Seem that it still uses the default error serializer rather than the custom one.

Altering the default serializer doesn't help either.

const stream = sink()
pino.stdSerializers.err = (e) => ({
  t: e.constructor.name,
  m: e.message,
  s: e.stack
})
const parent = pino({}, stream)

parent.info(ReferenceError('test'))
const o = await once(stream, 'data')
is(typeof o, 'object')
is(o.t, 'ReferenceError')
is(o.m, 'test')
is(typeof o.s, 'string')

[jsumners]

Because object inspection is expensive. We merely look for keys that have been configured to have serializers before attempting to apply any serializers. You are welcome to use the logMethod hook to alter this behavior if you like.

[YouriT]

That makes sense but what doesn't make sense is to be able to define a serializer that actually only works on nested key. It makes the behaviour non consistent.

What I was trying to achieve was solely to rename the stack key to exception in order to cover this case and I though I could achieve it with the err serializer but this behaviour prevents it.

[mcollina]

@YouriT #896 should solve this.

[YouriT]

@mcollina sure it does, many thanks! I was just trying to better illustrate what I meant when opening the issue

[Fdawgs]

Closed by #896

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.