Fix transpiled code loading #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2016805012
💛 - Coveralls |
mcollina
reviewed
Mar 18, 2022
|
Any idea on why the tests might be flaky? I see that they are not failing in a consistent manner. |
|
There are likely some bugs in some parts of the code. As long as we can get a clean / full green CI run we are good. |
castarco
force-pushed
the
fix-pinojs-pino-1243
branch
from
323b113
to
300852d
Compare
|
Update:
|
castarco
force-pushed
the
fix-pinojs-pino-1243
branch
from
65326a0
to
bf1cfe8
Compare
See pinojs/pino#1243 (comment) Added test confirming that there is a real issue, and that it is corrected.
castarco
force-pushed
the
fix-pinojs-pino-1243
branch
from
e74557d
to
d48825a
Compare
The added type declarations have been added for testing purposes, they need more love to be useful for package users.
- cover esnext code generation - use bash shell for tests in windows - wrap transpile script execution - use yarn as runner when testing yarn-pnp
castarco
force-pushed
the
fix-pinojs-pino-1243
branch
from
d48825a
to
f84f5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.tsfiles into worker threads when usingts-node(except in Windows).Not covered in this PR
Some potential improvements had to be left out of this PR to contain its scope:
.tsfiles into worker threads when running the code in Windows platforms.Extra comments
It seems that the coverage metrics have gone down mainly because of leaving out tests on Windows for the direct loading of
.tsfiles without transpilation. I'm not sure if I should explicitly document this lack of support, or if it's already enough stating it in the PR itself, as it's "just" a corner case.Related