Add readBlock to objectForKey & writeBlock to setObject:forKey:

[dimazen]

Generally this is a merge of https://github.com/tumblr/TMCache/pull/30/commits to PINCache.
Read & Write blocks are quite useful when object isn't compatible with NSCoding or manual action needs to be performed

[jparise]

Thanks for the contribution! Would you be willing to split this up into multiple pull requests (e.g. one that adds nonnull, etc. attributes to the current code, one that adds the new read/write blocks, etc.)? That would make it easier to review the functional changes on their own.

[dimazen]

@jparise should I remove nullability attributes and then make a diff branch with them?
What is the best way to do it?

[jparise]

Yes, that would be my preference. @garrettmoon is the primary maintainer, though, so let's see what he says.

[garrettmoon]

Hi Dima,

Thanks so much for the contribution!

I agree with Jon that splitting this up into multiple pull requests will make it easier to review and merge in. If you're willing to do that, it would be greatly appreciated!

On Mon, Jun 8, 2015 at 9:55 AM, Jon Parise notifications@github.com
wrote:

Yes, that would be my preference. @garrettmoon is the primary maintainer, though, so let's see what he says.

Reply to this email directly or view it on GitHub:
#6 (comment)

[dimazen]

I'll do my best tomorrow's morning ;)

[dimazen]

Sorry, @garrettmoon, I'm a bit busy atm, so waiting for the weekends

[garrettmoon]

Hey, no worries!

[dimazen]

Guys, having a really crazy pre-release weeks, sorry one more time

[dimazen]

@garrettmoon I reverted nullability attributes, check it!

[garrettmoon]

Thanks! I'll give this another look by EOD Friday.

[garrettmoon]

should be concurrentQueue

[dimazen]

Copy-paste got me :)

[garrettmoon]

This looks good! Aside from the few nits above, there's one other thing I'd request: many of the changes are whitespace changes that seem unnecessary and conflict with the existing whitespace patterns. Do you mind cleaning this up?

[dimazen]

@garrettmoon
Check out my fixes!

[dimazen]

@garrettmoon
Aside this PR can you also check other branches, that I have, maybe some of them can be useful for master repo:
feature/extension - saves key extension to disk, when you're passing key like "key.png". This one is useful, when you're using QLPreviewController - it can't identify object content-type without extension.

feature/object_at_path - allows you to set object at path. This is useful, when object is relatively big, so instead of explicit read and write NSFileManager used to simply copy / move file.

feature/trim_by_keys - this one is quite specific. It allows you to trim a defined set of keys to some date (heavily used in my current project cleanup of unused key with specific criteria)

[garrettmoon]

Is this necessary? What does it do?

[dimazen]

Strange why it gets commited.
I was trying to run tests from iOS target by cmd+u, however this one should be reverted..

[garrettmoon]

@dimazen Nice! And if you feel that the features would be widely useful to others, feel free to submit pull requests. One more question and I think we're there!

[garrettmoon]

I think I dropped the ball on this. The last question was, can you reformat your patch so it doesn't include all the whitespace changes? I know this is a pain, but it will help keep our git history. Thank you in advance!

[dimazen]

Argh, I've totally forgot about it, sure I will with no questions ;)

[garrettmoon]

Just to keep things clean, I'm going to close this. Feel free to reopen if you'd like to continue working on it.

[garrettmoon]

Or rather, let me know if you'd like to reopen :)