New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for tvOS #131
Conversation
@ioveracker awesome! I'll try and take a look at this as soon as I can! |
FYI, I'm releasing 2.0 very soon, but will make sure to release a 2.1 when we get this in :) |
@ioveracker I'm sorry this hasn't made it in yet, embarrassingly, I need to get our team on a newer version of cocoa pods which supports tvOS before I can merge. I'm going to work on that soon! 2.1 will be the tvOS release :) |
No worries! The FLAnimatedImage pull request is still pending as well. |
@ioveracker Just finished upgrading the team to CocoaPods so I'm swinging back around to this. I downloaded your branch to give it a try, but I'm not able to get the example to run in Example-tvOS. I get an import error on PINRemoteImage every time. I'm excited to have a Swift example and tvOS support landed :) Do you have any ideas what could be happening? I pod updated in the directory and that didn't work. |
Hm, I just did a clean clone, updated the Podfile to use my FLAnimatedImage repo (since that pull request is still pending over at FLAnimatedImage), ran Since it's using the local files for PINRemoteImage, maybe there's some crossover between work you've been doing on the master branch? I don't know if that's possible, because it should be building it from source, and when switched to the tvos branch, none of the changes from the master branch should be in the source. |
Crossover with the master branch is unlikely--I just pulled the latest master changes into my repo and even merged it into my local tvos branch and didn't encounter any issues. 😕 |
Ok, I'll give it another try with a clean clone! |
Coming back to this after a month, there are a couple things that I think could be changed (besides the fact that you can't get it to run! 😅) :
|
@ioveracker Cool! Maybe it will just work with the updates :P
Thanks for you work on this! |
Sounds good! I'll take a stab at these later this evening. |
Okay, I've taken care of the above three items, and rebased the latest changes from master.
I haven't been able to figure out why the Travis build is failing. Is it really being terminated because the log file is exceeding 4 MB just during the normal build, or is something else going on? I see a similar result in #308.1. |
@ioveracker ugh, yeah, travis has been a pain to get working correctly lately. Mind removing the verbose flag in the pod lint step in the .travis.yml file? |
Actually, I just removed it, so if you could just rebase, I'd appreciate it. |
- tvOS subspec excludes FLAnimatedImage (for now) - Removed GIF and WebP examples - Added Pods directory
No problem! Done. |
🎉 |
Thanks again, this is awesome! |
Sure thing! Thanks for all your hard work on PINRemoteImage, it's really great. |
Added tvOS to the podspec, plus an example project with similar scenarios as the iOS example. Things seem to be working well, but there are two exceptions:
pod "FLAnimatedImage", :git => "https://github.com/ioveracker/FLAnimatedImage", :branch => "tvos"
to the Podfile in Example-tvOS, above the line for PINRemoteImage.