Popover: Base implementation using Floating-UI #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
diyorbek
changed the title
diyorbek
commented
Oct 31, 2023
diyorbek
commented
Oct 31, 2023
diyorbek
commented
Oct 31, 2023
diyorbek
commented
Oct 31, 2023
| 'top': 'up', | ||
| }; | ||
|
|
||
| interface Props { |
There was a problem hiding this comment.
can we add a description of each prop here?
/**
* description
*/
| scrollBoundary?: HTMLElement, | ||
| }; | ||
|
|
||
| export default function Contents({ |
There was a problem hiding this comment.
Can we change name here or in File to NewContents.
I know locations / paths are different but I want to make sure we dont exhange them by misatke. we cant rerename in the future
There was a problem hiding this comment.
What about Experimental prefix? Or we can rename old ones with prefix Legacy.
There was a problem hiding this comment.
I'll leave it up to you. Legacy maybe makes more sense?
There was a problem hiding this comment.
Renamed old one with Legacy prefix
AlbertCarreras
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-implemented core internal components of Popover using Floating-UI.
New implementation is not exposed. This is the first PR of gradual rehaul of Popover and Popover based components.
The changes include:
disablePortalprop for InternalPopoverscrollBoundaryprop for InternalPopoverhideWhenReferenceHiddenprop for InternalPopover (open for shorter prop name suggestions)What changed?
Why?
Links
Checklist