Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 7 warnings "Method override for the designated initializer not found" #61

Closed
alexvimpekable opened this issue Sep 16, 2015 · 3 comments
Closed

Xcode 7 warnings "Method override for the designated initializer not found" #61

alexvimpekable opened this issue Sep 16, 2015 · 3 comments
Assignees
@garrettmoon

Comments

@alexvimpekable
Copy link

Both PINCache and PINDiskCache triggers Xcode 7 warnings "Method override for the designated initializer of the superclass '-init' not found". They should probably just return shared instance on init or it might be marked as NS_UNAVAILABLE.
@jparise
Copy link
Collaborator

jparise commented Sep 16, 2015

Those were fixed by pinterest/PINCache#25. We should do a new PINCache release shortly, and once that's out, we'll update the PINCache dependency in PINRemoteImage.

@jparise
Copy link
Collaborator

jparise commented Sep 21, 2015

PINCache 2.1 has been released with a fix for this. We should also updated PINRemoteImage's PINCache dependency.

@garrettmoon
Copy link
Collaborator

Updated to 1.2 with PINCache 2.1 dependency.

tinder-garricnahapetian pushed a commit to TinderApp/PINRemoteImage that referenced this issue Mar 22, 2024
@garrettmoon
Merge pull request pinterest#61 from b123400/escape
e2abd6e 
Fixed bug that % is not properly escaped (PINDiskCache)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettmoon garrettmoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jparise @garrettmoon @alexvimpekable