Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kotlin-friend Java method names for Boolean accessors #248

Open
jparise opened this issue Sep 10, 2019 · 0 comments
Open

Use Kotlin-friend Java method names for Boolean accessors #248

jparise opened this issue Sep 10, 2019 · 0 comments
Labels

Comments

@jparise
Copy link
Contributor

jparise commented Sep 10, 2019

From Calling Java code from Kotlin:

Boolean accessor methods (where the name of the getter starts with is and the name of the setter starts with set) are represented as properties which have the same name as the getter method.

This could be a nice improvement for our generated "is set" methods. We currently name them get{Property}IsSet() (e.g. getHeightIsSet()), but we could instead name them is{Property}Set() (e.g. isHeightSet()).

We could also consider doing something similar for declared Boolean property accessors, but we'd need to be more thoughtful about unexpected results if we start changing property names to match this convention.

@jparise jparise added the java label Sep 10, 2019
@jparise jparise changed the title Use Kotlin-friend Java method names for Boolean properties Use Kotlin-friend Java method names for Boolean accessors Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant