Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS reserved property name #78

Closed
brurend opened this issue Sep 15, 2017 · 7 comments
Closed

iOS reserved property name #78

brurend opened this issue Sep 15, 2017 · 7 comments

Comments

@brurend
Copy link

brurend commented Sep 15, 2017

I had issues with a few variable names that are reserved, I know that plank handle a few of them (id, description), but not all. I had issues with "class" and "continue".

Is there anything that I can do to avoid this problem?

@rahul-malik
Copy link
Collaborator

@brurend - Yes we just need to add substitutions for objc reserved keywords. If you'd like to add these cases and put up a PR you can add them here:

https://github.com/pinterest/plank/blob/92c9a3f4719a7bf71b595b2da8e7bcd257c208f5/Sources/Core/StringExtensions.swift

@rahul-malik
Copy link
Collaborator

I just put up a PR to address this #79

@brurend
Copy link
Author

brurend commented Sep 18, 2017

Thats great, thank you

@rahul-malik
Copy link
Collaborator

@brurend @CavalcanteLeo - PR landed. Feel free to build off of the latest master and let me know if this fixes the issue for you! This patch and others will need to go through more stress testing before it's in an official release.

@CavalcanteLeo
Copy link

Thank you very much! Just waiting for the release

@CavalcanteLeo
Copy link

CavalcanteLeo commented Oct 18, 2017

It still uses class as property. @rahul-malik

captura de tela 2017-10-18 as 12 36 19

@maicki
Copy link
Contributor

maicki commented Oct 21, 2017

@CavalcanteLeo class is not an objc reserved word, it should be totally fine to use it as a property. @class and Class are reserved keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants