Use copy for NSURL and NSDate

[Adlai-Holler]

This is pretty pedantic, but technically correct and it will improve the world for the 0 developers who created MYMutableDate : NSDate and set that on a builder object.

[maicki]

Love it - The 0 developer crowd will cheer after this PR will go in!

[rahul-malik]

@Adlai-Holler - Looks good, mind running make integration_test to update the snapshot tests and updating the PR?

[ghost]

	1 Warning
⚠️	Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

[ghost]

🚫 CI failed with log

[Adlai-Holler]

@rahul-malik So running that gave me a ton of Swiftlint errors. Thoughts?

[04:15:32] ~/code/plank (AHUseCopyMore)  $ make integration_test
./Utility/lint.sh
Error: Fix lint errors from swiftlint
/Users/adlai/code/plank/Sources/Core/FileGenerator.swift ⚠️ Line 109: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 11: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. /Users/adlai/code/plank/Sources/Core/JSModelRenderer.swift ⚠️ Line 52: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. /Users/adlai/code/plank/Sources/Core/ObjCADTRenderer.swift ⚠️ Line 202: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 199: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. /Users/adlai/code/plank/Sources/Core/ObjCModelRenderer.swift ⚠️ Line 118: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. /Users/adlai/code/plank/Sources/Core/ObjectiveCFileGenerator.swift ⚠️ Line 96: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. /Users/adlai/code/plank/Sources/Core/ObjectiveCIR.swift ⚠️ Line 401: File should contain 400 lines or less: currently contains 401 /Users/adlai/code/plank/Sources/Core/ObjectiveCNSCodingExtension.swift ⚠️ Line 119: Case statements should vertically align with the enclosing switch statement. ⚠️ Line 117: Case statements should vertically align with the enclosing switch statement. ⚠️ Line 115: Case statements should vertically align with the enclosing switch statement. ⚠️ Line 113: Case statements should vertically align with the enclosing switch statement. ⚠️ Line 111: Case statements should vertically align with the enclosing switch statement. /Users/adlai/code/plank/Sources/Core/Schema.swift ⚠️ Line 289: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 146: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 125: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 112: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 89: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 89: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 11: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. /Users/adlai/code/plank/Sources/Core/SchemaLoader.swift ⚠️ Line 18: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. /Users/adlai/code/plank/Sources/plank/Cli.swift ⚠️ Line 177: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 93: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 55: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. ⚠️ Line 40: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.
make: *** [lint] Error 1

[rahul-malik]

@adlai you might be running a different version of swift-lint than me.

[adlai]

@Adlai-Holler control your devops damnit
@adlai is me. @Adlai-Holler is that dude. @rahul-malik pls.

[Adlai-Holler]

@adlai Userpic is ironic

[adlai]

Yeah, I even got that on a shirt! Great at parties.

[rahul-malik]

@adlai - @Adlai-Holler is "that dude"? as in "the dude abides"?

[rahul-malik]

Closed in favor of #103