Skip to content

Commit

Permalink
ci coverage fix
Browse files Browse the repository at this point in the history
Former-commit-id: fbcc0a2
  • Loading branch information
tarrencev committed Jun 30, 2020
1 parent 0c2a17f commit 5e54918
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 16 deletions.
3 changes: 1 addition & 2 deletions Makefile
@@ -1,7 +1,6 @@
GO_LDFLAGS = -ldflags "-s -w"
GO_VERSION = 1.14
GO_TESTPKGS:=$(shell go list ./... | grep -v cmd | grep -v conf | grep -v node | grep -v examples | grep -v proto)
GO_COVERPKGS:=$(shell echo $(GO_TESTPKGS) | paste -s -d ',')
TEST_UID:=$(shell id -u)
TEST_GID:=$(shell id -g)

Expand All @@ -28,5 +27,5 @@ nodes: go_deps

test: nodes
go test \
-coverpkg=${GO_COVERPKGS} -coverprofile=cover.out -covermode=atomic \
-coverprofile=cover.out -covermode=atomic \
-v -race ${GO_TESTPKGS}
9 changes: 0 additions & 9 deletions codecov.yml
@@ -1,9 +1,3 @@
#
# DO NOT EDIT THIS FILE DIRECTLY
#
# It is automatically copied from https://github.com/pion/.goassets repository.
#

coverage:
status:
project:
Expand All @@ -14,6 +8,3 @@ coverage:

ignore:
- "cmd/*"
- "cmd/**/*"
- "pkg/node/*"
- "pkg/node/**/*"
11 changes: 6 additions & 5 deletions pkg/rtc/router.go
Expand Up @@ -53,6 +53,7 @@ func NewRouter(id string) *Router {
}
}

// InitPlugins initializes plugins for the router
func (r *Router) InitPlugins(config plugins.Config) error {
log.Infof("Router.InitPlugins config=%+v", config)
if r.pluginChain != nil {
Expand Down Expand Up @@ -103,7 +104,7 @@ func (r *Router) start() {
}()
}

// AddPub add a pub transport
// AddPub add a pub transport to the router
func (r *Router) AddPub(t transport.Transport) transport.Transport {
log.Infof("AddPub")
r.pub = t
Expand All @@ -115,12 +116,12 @@ func (r *Router) AddPub(t transport.Transport) transport.Transport {
return t
}

// delPub del pub
// delPub
func (r *Router) delPub() {
log.Infof("Router.delPub %s", r.pub.ID())
// if r.pub != nil {
// r.pub.Close()
// }
if r.pub != nil {
r.pub.Close()
}
if r.pluginChain != nil {
r.pluginChain.Close()
}
Expand Down

0 comments on commit 5e54918

Please sign in to comment.