Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packetizer should optionally add abs-send-time extension to packet-sets #54

Closed
wdouglass opened this issue Mar 26, 2019 · 3 comments
Closed

Comments

@wdouglass
Copy link
Member

Summary

libwebrtc on android really wants abs-send-time to be enabled
https://webrtc.org/experiments/rtp-hdrext/abs-send-time/

Motivation

I believe that libwebrtc.aar isn't interpreting stream timestamps without this extension, and choppy video is the result. Even if i'm wrong about this, getting closer to feature-parity with webrtc.org isn't a bad thing.

wdouglass referenced this issue in pion/rtp Mar 26, 2019
wdouglass referenced this issue in pion/rtp Mar 26, 2019
wdouglass referenced this issue in pion/rtp Mar 27, 2019
wdouglass referenced this issue in pion/rtp Mar 27, 2019
wdouglass referenced this issue in pion/rtp Mar 27, 2019
wdouglass referenced this issue in pion/rtp Mar 27, 2019
wdouglass referenced this issue in pion/rtp Mar 27, 2019
wdouglass referenced this issue in pion/rtp Mar 27, 2019
* ntp timestamp conversion
* RTP Extension validation

Relates to #15
wdouglass referenced this issue in pion/rtp Mar 27, 2019
wdouglass referenced this issue in pion/rtp Mar 27, 2019
* ntp timestamp conversion
* RTP Extension validation

Relates to #15
wdouglass referenced this issue in pion/rtp Mar 28, 2019
* ntp timestamp conversion
* RTP Extension validation
* H264 payloader

Relates to #15
wdouglass referenced this issue in pion/rtp Mar 28, 2019
and reverse an import dependancy

Relates to #15
wdouglass referenced this issue in pion/rtp Mar 28, 2019
and reverse an import dependancy

Relates to #15
wdouglass referenced this issue in pion/rtp Mar 29, 2019
wdouglass referenced this issue in pion/rtp Apr 2, 2019
wdouglass referenced this issue in pion/rtp Apr 2, 2019
* ntp timestamp conversion
* RTP Extension validation
* H264 payloader

Relates to #15
wdouglass referenced this issue in pion/rtp Apr 2, 2019
and reverse an import dependancy

Relates to #15
wdouglass referenced this issue in pion/rtp Apr 2, 2019
@Sean-Der
Copy link
Member

We have abs support pion/rtp@6b0d25a! Not closing because it still needs to be added to the packetizer itself.

@Sean-Der
Copy link
Member

This should be an interceptor, and as close to the end as possible

@Sean-Der Sean-Der transferred this issue from pion/rtp Aug 6, 2021
@Sean-Der
Copy link
Member

Sean-Der commented Aug 6, 2021

Actually this was implemented it looks like! pion/rtp@a8ed4cb

@Sean-Der Sean-Der closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants