Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential regression by a commit c0159aa in causing TestAssociation_Shutdown to fail #250

Closed
enobufs opened this issue Nov 20, 2022 · 5 comments
Closed

Potential regression by a commit c0159aa in causing TestAssociation_Shutdown to fail #250

enobufs opened this issue Nov 20, 2022 · 5 comments

Comments

@enobufs
Copy link
Member

enobufs commented Nov 20, 2022 

    @enobufs Just wondering: could it be that this PR (commit c0159aa2d49c240362038edf88baa8a9e6cfcede) introduced a regression which makes the unit-test `TestAssociation_Shutdown` fail?

See https://github.com/pion/sctp/actions/runs/3495811764/jobs/5852996166

Originally posted by @stv0g in #239 (comment)
@enobufs
Copy link
Member Author

enobufs commented Nov 20, 2022

Hi @jerry-tao, @stv0g, are you able to repro this in your environment? The error does not happen to me... :(

@jerry-tao
Copy link
Member

I did not reproduce it either, will dig deeper this week.

@stv0g
Copy link
Member

stv0g commented Nov 21, 2022

I just tested it again on the current master branch and the test succeeded.

But I see a possibly related PR #236

@stv0g
Copy link
Member

stv0g commented Dec 7, 2022

I tried to produce it again without success.

So maybe I've dreamt it...

@stv0g stv0g closed this as completed Dec 7, 2022
@edaniels
Copy link
Member

I just saw it again but only on 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stv0g @edaniels @enobufs @jerry-tao