Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.Raw allocate is to small #20

Closed
newzai opened this issue Jul 19, 2019 · 2 comments
Closed

m.Raw allocate is to small #20

newzai opened this issue Jul 19, 2019 · 2 comments
Labels

Comments

@newzai
Copy link

newzai commented Jul 19, 2019

Your environment.

  • Version: Release or SHA
  • Browser: include version
  • Other Information - stacktraces, related issues, suggestions how to fix, links for us to have context

What did you do?

What did you expect?

m.Raw = make([] byte, 2048)

What happened?

clinet.go readUntiClosed , the m.Raw allocate buffer 1024 is to small , some DTLS data is big ,more then 1024,will raise the data is lost by local memory,

@Sean-Der
Copy link
Member

Hey @newzai Thanks for the issue!

For pion/ice we only use m.Raw if we know something is a STUN packet. https://github.com/pion/ice/blob/master/candidate_base.go#L103

Are you talking about the cmd/stun-multiplex example? If you want to increase the buffer size I am happy to approve the PR!

thanks for using Pion :)

@Sean-Der
Copy link
Member

Hi @newzai

I am closing this issue since we haven't heard back from you. Please re-open if this is still an issue!

Thanks for using Pion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants