SGModel gear disappearing when fully deployed

[robn]

Forum user Vuzz posted this video demonstrating the Lanner gear disappearing when fully deployed: http://www.youtube.com/watch?v=fUxm_MIl8uo

This is not what I see, but I'm on a different platform.

We did discuss it a little this morning, and @jaj22 had a theory:

<JohnJ> hmm. Maybe there's an fp-rounding issue where frame comes out as the last frame rather than the penultimate.
<JohnJ> And then nextFrame becomes the first frame.
<JohnJ> (animation::Interpolate(), line 79)

Probably worth checking out.

[Metamartian]

just to chip in as well. I also see the issue in the modelviewer. It's right at the end of the animation slider. 0.99 in fine but it disappears at 1.00.

Platform PC

[johnbartholomew]

@Metamartian Could you try editing the .model file (data/models/ships/lanner/lanner.model), change this line:

anim gear_down 1 100

To this:

anim gear_down 1 99

[VuzzVoom]

hi , i have the same problem like Metamartian on MV .

also try to modif anim gear_down to 1 99

that don't work , the landing gear rest in the hull , and only the flaps move down

(also try 1 101 , same result)

[Metamartian]

solved it. I remembered something that fluffy told me. The animations actually start at 0
so

anim gear_down 0 100

fixes it on windows anyway :)

[VuzzVoom]

i confirm , every things rule ok ,

[johnbartholomew]

The actual animation in Blender runs from frame 1 to frame 100, and the time values in the exported lanner.dae file match that; the first keyframe is at 0.04166662 (which is 1/24; i.e., frame 1 at 24 FPS). So we can use 0 to 100 as a work-around, but I think that is not completely correct. Hopefully we can find the problem and fix it properly so it won't happen again for other models.

[Metamartian]

damn I thought I was being too clever :)

[johnbartholomew]

This should be fixed by #1978.

The latest nightly has this patch. Testing would be appreciated. Please re-open/comment on the issue if you still see this bug in the nightly.