Show altitude and vertical speed even when farther away from planet #2446
Conversation
|
Hmm, I wonder if it should have special handling for orbital starports to show the height above the parent planet? For surface starports this is not needed as they have no own frame. |
| Pi::cpan->SetOverlayText(ShipCpanel::OVERLAY_BOTTOM_RIGHT, ""); | ||
| else { | ||
| double vspeed = vel.Dot(Pi::player->GetPosition().Normalized()); |
There was a problem hiding this comment.
If you hover above a planet with Set Speed mode to keep your velocity at 0, changing numerical errors make vspeed flicker between positive and negative zero. This needs a threshold (with an explanatory comment) to truncate values that are close to zero to be exactly (positive) zero to stop the display flickering.
|
This is mostly fine. I've written a few comments on the diff about some details that could be improved. |
|
So, I hope it's much clearer now (and correct ;)). That innocent looking fix for orbital stations did break quite a few places. |
Currently the altitude is only shown when in the rotating frame of the planet. The rotating frame ends beyond atmosphere or highest mountains (whichever is higher). This PR changes this to show the altitude up to 10000km or 0.5 planet radii (whichever is lower). For more than 100km the altitude is shown in km instead of m.
Furthermore, the vertical speed is shown together with the altitude. Note: This is really the vertical speed, not the change in altitude, i.e. it will show zero when you fly horizontal, but the altitude may nevertheless drop if you fly above raising terrain.