Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup and use the RenderTargets. #2525

Merged
merged 8 commits into from Jan 2, 2014
Merged

Conversation

fluffyfreak
Copy link
Contributor

These have been in for months without being used!

These have been in for months without being used!
@fluffyfreak
Copy link
Contributor Author

The reason for doing this by the way is because it makes a good base for fullscreen effect and is necessary for the Oculus Rift support I've long been developing. I'd rather get it in one piece at a time rather than some huge super-commit.

@robn
Copy link
Member

robn commented Nov 5, 2013

Instant crash on the legacy renderer :(

What can I do to actually test that this works?

@fluffyfreak
Copy link
Contributor Author

Legacy, balls.

@fluffyfreak
Copy link
Contributor Author

I suppose I can add some checks to not use it if we're using the legacy renderer, it's getting quite inconvenient now.
It means no fullscreen effects, rendering the GUI to textures and displaying on things, no 3D instrumentation, no Oculus etc.
OpenGL 2.0 came out in 2004 ... bah

@robn
Copy link
Member

robn commented Nov 6, 2013

I re-asked the forum if we can kill legacy. Lets see :)

@fluffyfreak
Copy link
Contributor Author

Updated to master

@fluffyfreak
Copy link
Contributor Author

Dropping this in favour of backporting the Post-Processing work done for Paragon

@fluffyfreak fluffyfreak reopened this Jan 1, 2014
@fluffyfreak
Copy link
Contributor Author

I realised why I ever wanted this committing!
For one thing it's what I built the damned Oculus Rift support atop and I want to extend it eventually for GUI render targets and picture-in-picture cameras.
It's been so long that I'd forgotten.

@robn
Copy link
Member

robn commented Jan 1, 2014

How do I test this?

@fluffyfreak
Copy link
Contributor Author

Compile and run, if you can see something then it's worked :)

@robn
Copy link
Member

robn commented Jan 1, 2014

Yeah ok, its works :)

Direct GL calls in Pi.cpp are bad. They'll need to go into the renderer somewhere sane. My brain isn't firing right now (badly need sleep) but I'll try to suggest something soon.

@fluffyfreak
Copy link
Contributor Author

Ok, i've got a change coming but run out of time to get it working properly. off to be now :)

@fluffyfreak
Copy link
Contributor Author

Ok, think that's done it... NOW i'm off to bed :)

@robn robn merged commit f9ce69f into pioneerspacesim:master Jan 2, 2014
@robn
Copy link
Member

robn commented Jan 2, 2014

Merged with few style and sanity fixes.

I'm really unhappy with the complete lack of structure and proper integration here, but I don't have the mental space right now to figure out how it should all fit together. Its contained enough and commented enough to not be an immediate problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants