Modify Serializer::Reader to work from an externally provided ByteRange #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the pointless allocation and copying that happened when Reader had its own copy of the data in a std::string, and makes it easy to create a Reader to deserialise data from a FileData object (ie, easy to use with FileSystem).
|
Quick test of saving/loading worked just fine :) |
|
Merged. @fluffyfreak Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2643.
This eliminates the pointless allocation and copying that happened when Reader had its own copy of the data in a std::string, and makes it easy to create a Reader to unserialise data from a FileData object (ie, easy to use with FileSystem).
(warning: completely untested apart from checking that it compiles)