cargo gauge - EconTrade.lua

[radius75]

https://github.com/pioneerspacesim/pioneer/blob/master/data/ui/InfoView/EconTrade.lua#L81
https://github.com/pioneerspacesim/pioneer/blob/master/data/ui/InfoView/EconTrade.lua#L107

it seems to me that there should be:
player.usedCargo/(player.freeCapacity+player.usedCargo) % calculated for total space for cargo

[radius75]

like here
https://github.com/pioneerspacesim/pioneer/blob/master/data/ui/StationView.lua#L44

[radius75]

and yet here
https://github.com/pioneerspacesim/pioneer/blob/master/data/ui/InfoView/EconTrade.lua#L78
("%d/%dt", player.usedCargo, (player.freeCapacity+player.usedCargo)) actual cargo/total space for cargo

[impaktor]

I've looked into this (code, and tested its behaviour in game)

L81, and L107 are, as you point out, definitley wrong, and should have the form you suggest.

L78 is good as it is, since we want to show just this, i.e. how much cargo space is in use vs. how much cargo space is free.

I'd suggest you make a pull request fixing L81, and L107.

[radius75]

since we want to show just this, i.e. how much cargo space is in use vs. how much cargo space is free.

I think the label "Cargo space" should be more understandable: "Cargo/Free space"
The player has to guess what is (for example) 1/1 :)

[impaktor]

On second thoughts, I withdraw my statement about L78. Maybe it should be as it is now used / free, or maybe it should show used / total. I don't know which is of most value to the user.

[robn]

Closed by #2657.