Intro tweaks and cleanup

[robn]

Intro doesn't get much love. Today it does :)

• Don't make direct GL calls
• Use a larger viewport to avoid clipping
• Don't spin vertically, its kind of nauseating
• Randomise skin and pattern for each ship display. No two ships the same, guaranteed!†

† Not a guarantee

[robn]

Github is having a braino. Its the last four commits. The rest are on master already.

[fluffyfreak]

Code all looks good to me :)

[walterar]

User test: pass 👍

[laarmen]

Do not merge yet, I have a bug. I still have to check whether it was there beforehand or a regression, but basically the first ship stays far away until a few milliseconds before it is supposed to disappear, at which point it jumps out in front of me, and then goes away as it is supposed to. The following ships behave normally.

[fluffyfreak]

@laarmen I think that was already there, if you got a stall or hitch in the framerate then it would skip and get stuck with a ship in the wrong position.

[laarmen]

OK, i'll merge later tonight then.
Le 14 janv. 2014 20:21, "Andrew Copland" notifications@github.com a écrit
:

@laarmen https://github.com/laarmen I think that was already there, if
you got a stall or hitch in the framerate then it would skip and get stuck
with a ship in the wrong position.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2649#issuecomment-32297717
.

[robn]

Yeah, that bug was there but I'd forgotten it, and I never quite understood what it was anyway. Thatnks @fluffyfreak, that should be easy to fix. But another time, got different stuff to do today.

@laarmen thanks :)

[fluffyfreak]

Yeah I kept meaning to look into it, but y'know what it's like! :)

[robn]

Rebased to current master, which seems to have de-confused Github.

More importantly, I think I fixed the bug. Instead of having discrete state change points, it now determines the right place in the animation each frame and does the right thing.

[fluffyfreak]

I've got to learn to rebase, every time I've tried to use it on windows I just get constant conflicts. Even on a clean branch! :/

Anyway, that aside the code changes to fix the intro looks good.