Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sectorview star optimization #2713

Merged
merged 2 commits into from Feb 3, 2014
Merged

Conversation

Luomu
Copy link
Member

@Luomu Luomu commented Feb 2, 2014

  • Instead of drawing each star with a separate drawcall, collect them into a batch and draw everything at once
  • Instead of Drawables::Disk, use a billboard sphere impostor. Perfect little spheres from any distance, with only 4 vertices each.
  • Add a bit of shading to each sphere. Someone might later want to tweak the light direction to come from the player, the galactic core or something.

screenshot-20140202-155133

@lwho
Copy link
Contributor

lwho commented Feb 2, 2014

Looks a lot better than those flat disks.

One nitpick: The darker parts of the spheres are darker than the hyperjump sphere, which sometimes looks a bit strange. Maybe the spheres shouldn't go to pure black.

@robn robn merged commit 42568d6 into pioneerspacesim:master Feb 3, 2014
@fluffyfreak
Copy link
Contributor

Hah, good timing @robn! I was just reviewing this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants