Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some orbital data in Sol system #3889

Merged
merged 4 commits into from Feb 24, 2017

Conversation

ecraven
Copy link
Contributor

@ecraven ecraven commented Dec 8, 2016

Fix the orbits of Metis, Adrastea and Rhea to be correct and synchronous.
Add Saturn III, Tethys
Add the minor planets 2 Pallas, 4 Vesta and 1 Ceres
(3 Juno is only the 11th largest asteroid)

@ecraven
Copy link
Contributor Author

ecraven commented Dec 8, 2016

The orbital data are all taken from wikipedia. The "looks" are most certainly all totally wrong, but the orbits are correct (except for the phases / anomalies, I haven't calculated them for 3200 yet :-/)

@impaktor
Copy link
Member

impaktor commented Dec 9, 2016

Just read the backlog from last night.

  1. planet phases are correct for 3200
  2. This might need save bump

@impaktor
Copy link
Member

impaktor commented Dec 9, 2016

To elaborate on my point above, in #3135 the correct phases of the planets were included, based on the table I posted there, so it should be correct in master.

@fluffyfreak
Copy link
Contributor

So is this ready for merge then?
I'm afraid I don't understand the conversions enough to comment on whether they're correct or not.

@laarmen
Copy link
Contributor

laarmen commented Dec 19, 2016

Do we have anything in the tubes requiring a savebump?

@fluffyfreak
Copy link
Contributor

I don't think so.

@impaktor
Copy link
Member

Do we have anything in the tubes requiring a savebump?

Might be that with the large imgui work something might pop up?

Maybe this shouldn't savebump, because chance of player actually being affected is low? Or is there some actual body-index change?

@fluffyfreak
Copy link
Contributor

Yeah this might be ok without the savebump.

@impaktor
Copy link
Member

There are some terrain gen stuff that have been discussed to be changed. Not sure if/how/when.

Also, from IRC,

<fellowExplorer> visit Groombridge 1618 b, that one rotates so fast that the
                 equatorial regions are moving over escape velocity, your will
                 just lift off into space from it's surface!  bug/feature , or
                 just intended strangeness off space? :)                [00:40]

@fluffyfreak fluffyfreak merged commit c9a1327 into pioneerspacesim:master Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants