Collision with docking surface entirely moved on SpaceStation #3920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to correct a new bug, easily reproducible: you start at earth, take-off then try
to hit spaceport landing surface: you can pass through it :/
After last changes, ground station have no more two layers of collision mesh (one not flagged
and one flagged) but only a flagged flat surface.
This means less work for collision system, and also for modellers. More, this not rely on
eight of "mushroom-shaped" collision meshes and is definitely a step ahead.
But this means also you need to bounce (collide) with flagged surfaces if you're not trying
to dock (this is specific for planet starport), OR you need to pass through collision volume
when you aren't docking and you want to fly through the central hole of orbital stations..
To solve this I removed the collision checks for flagged surfaces from Ship and put things
on SpaceStation. Now, if SpaceStation detect an hit with Ships, is entirely responsible for
reaction: if Ships are docking, then:
Else (so when Ships aren't docking):
method called actually) and return true, letting Space to "bounce" Ship.
A side effect of this change is that you no longer have damages on Ships even at high time accel
and even if you have flat hull or tag_landing not well positioned (under some limit...).