Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EasterEgg: Call onDelete if removed #4334

Merged
merged 1 commit into from May 22, 2018

Conversation

robothauler
Copy link
Contributor

Fixes #4329

@impaktor
Copy link
Member

Ah, good. I had a feeling I've missed something. In fact, I was thinking, it shouldn't need saving/loading state at all, since it's fixed to the station, and never goes away, or changes, so I had a thought some time ago, to remove the seralize/unserialize functions.

@robothauler
Copy link
Contributor Author

I pushed it again because I forgot onGameStart.

@fluffyfreak
Copy link
Contributor

Code looks good to me, but I'll leave this review to @impaktor :)

@impaktor impaktor merged commit 6ce3315 into pioneerspacesim:master May 22, 2018
@impaktor
Copy link
Member

👍 for branch name!

@impaktor
Copy link
Member

So, the bug was, if visiting a system with an "egg", then visiting another system, the BBS would try to use that egg, I think, (just running the code very sloppily in my brain).

@robothauler robothauler deleted the spoiled_eggs branch May 25, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants