Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelcompiler sometimes fails to build any .sgm files. #4730

Open
orbea opened this issue Nov 1, 2019 · 0 comments

Comments

@orbea
Copy link
Contributor

@orbea orbea commented Nov 1, 2019

Observed behaviour

If pioneer is installed to the system then the next time pioneer is built modelcompiler will skip creating any .sgm files which already exist on the system.

When creating distro packages this is very problematic because the created packages are not reproducible if they are already installed.

The problem seems to be somewhere around here where ends_with_ci will never be true and the .sgm files are never created.

if (ends_with_ci(fpath, ".model")) { // store the path for ".model" files

Edit:

Its returning false in ends_with_ci here.

if (tolower(*s++) != tolower(*t++)) return false;

Expected behaviour

Pioneer should always generate .sgm files during the build.

Steps to reproduce

  1. Build and install pioneer using -DPIONEER_DATA_DIR=/usr/share/pioneer.
    2, Now rebuild pioneer with a fresh build directory using the same directory as in the previous step, -DPIONEER_DATA_DIR=/usr/share/pioneer.
  2. The modelcompiler will skip creation of any .sgm files since they already exist at /usr/share/pioneer/.
  3. If creating a package the new package will be missing all of the .sgm files which will then vanish from the system when the package is upgraded.

My pioneer version (and OS):

OS: Slackware64-current
pioneer: 9fc04e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.