Optimize Read with buffering #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kixelated
force-pushed
the
read-buffer
branch
6 times, most recently
from
f19847f
to
54d1a41
Compare
Sean-Der
reviewed
Mar 7, 2019
stream_srtp.go
Outdated
|
|
||
| // Create a buffer with a 1MB limit | ||
| r.buffer = packetio.NewBuffer() | ||
| r.buffer.SetLimitSize(1000 * 1000) |
There was a problem hiding this comment.
Can you make this a constant and pull it out of the function (just for visibility)
Sean-Der
reviewed
Mar 7, 2019
stream_srtcp.go
Outdated
|
|
||
| // Create a buffer and limit it to 100KB | ||
| r.buffer = packetio.NewBuffer() | ||
| r.buffer.SetLimitSize(100 * 1000) |
Sean-Der
approved these changes
Mar 7, 2019
kixelated
changed the title
|
This LGTM! Lets wait to merge until |
This avoids channel/lock coordination in favor of performing a copy and always adding the packet to a queue. Obviously I hate performing copies, but I think this is the fastest approach with the current API. This fixes much of the packet loss on the reader side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids channel/lock coordination in favor of performing a copy and
always adding the packet to a queue. Obviously I hate performing copies,
but I think this is the fastest approach with the current API.
Along with switching webrtc to using this package, this reduces packet loss
on the reader size from roughly 8% to 0.5%.
I wrote an implementation similar to the old code for comparison sake.