Skip to content

Commit

Permalink
Expose Encodings variable for ORTC
Browse files Browse the repository at this point in the history
It's not possible to use a RTPReceiver without it.
  • Loading branch information
kixelated authored and Sean-Der committed Feb 26, 2019
1 parent 6aeb342 commit 7f3f9f1
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Check out the **[contributing wiki](https://github.com/pions/webrtc/wiki/Contrib
* [Rob Deutsch](https://github.com/rob-deutsch) *RTPReceiver graceful shutdown*
* [Jin Lei](https://github.com/jinleileiking) - *SFU example use http*
* [Will Watson](https://github.com/wwatson) - *Enable gocritic*
* [Luke Curley](https://github.com/kixelated)

### License
MIT License - see [LICENSE](LICENSE) for full text
4 changes: 2 additions & 2 deletions peerconnection.go
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ func (pc *PeerConnection) SetRemoteDescription(desc SessionDescription) error {
for _, tranceiver := range pc.rtpTransceivers {
if tranceiver.Sender != nil {
err = tranceiver.Sender.Send(RTPSendParameters{
encodings: RTPEncodingParameters{
Encodings: RTPEncodingParameters{
RTPCodingParameters{
SSRC: tranceiver.Sender.track.SSRC(),
PayloadType: tranceiver.Sender.track.PayloadType(),
Expand Down Expand Up @@ -940,7 +940,7 @@ func (pc *PeerConnection) openSRTP() {
}

if err = receiver.Receive(RTPReceiveParameters{
encodings: RTPDecodingParameters{
Encodings: RTPDecodingParameters{
RTPCodingParameters{SSRC: ssrc},
}}); err != nil {
pcLog.Warnf("RTPReceiver Receive failed %s", err)
Expand Down
2 changes: 1 addition & 1 deletion rtpreceiveparameters.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package webrtc

// RTPReceiveParameters contains the RTP stack settings used by receivers
type RTPReceiveParameters struct {
encodings RTPDecodingParameters
Encodings RTPDecodingParameters
}
6 changes: 3 additions & 3 deletions rtpreceiver.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (r *RTPReceiver) Receive(parameters RTPReceiveParameters) error {

r.track = &Track{
kind: r.kind,
ssrc: parameters.encodings.SSRC,
ssrc: parameters.Encodings.SSRC,
receiver: r,
}

Expand All @@ -67,7 +67,7 @@ func (r *RTPReceiver) Receive(parameters RTPReceiveParameters) error {
return err
}

srtpReadStream, err := srtpSession.OpenReadStream(parameters.encodings.SSRC)
srtpReadStream, err := srtpSession.OpenReadStream(parameters.Encodings.SSRC)
if err != nil {
return err
}
Expand All @@ -77,7 +77,7 @@ func (r *RTPReceiver) Receive(parameters RTPReceiveParameters) error {
return err
}

srtcpReadStream, err := srtcpSession.OpenReadStream(parameters.encodings.SSRC)
srtcpReadStream, err := srtcpSession.OpenReadStream(parameters.Encodings.SSRC)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion rtpsender.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (r *RTPSender) Send(parameters RTPSendParameters) error {
if err != nil {
return err
}
srtcpReadStream, err := srtcpSession.OpenReadStream(parameters.encodings.SSRC)
srtcpReadStream, err := srtcpSession.OpenReadStream(parameters.Encodings.SSRC)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion rtpsendparameters.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package webrtc

// RTPSendParameters contains the RTP stack settings used by receivers
type RTPSendParameters struct {
encodings RTPEncodingParameters
Encodings RTPEncodingParameters
}

0 comments on commit 7f3f9f1

Please sign in to comment.