Skip to content

Commit

Permalink
Upgrade to pions/sdp v2
Browse files Browse the repository at this point in the history
Relates to #417
  • Loading branch information
maxhawkins authored and Sean-Der committed Feb 18, 2019
1 parent 6567fca commit 9cba54c
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion go.mod
Expand Up @@ -6,7 +6,7 @@ require (
github.com/pions/rtcp v1.0.0
github.com/pions/rtp v1.0.0
github.com/pions/sctp v1.3.1
github.com/pions/sdp v1.3.0
github.com/pions/sdp/v2 v2.0.0
github.com/pions/srtp v1.0.3
github.com/pions/stun v0.2.0
github.com/pions/transport v0.1.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Expand Up @@ -32,8 +32,8 @@ github.com/pions/rtp v1.0.0/go.mod h1:GDIt4UYlSz7za4vfaLqihGJJ+yLvgPshnqrF/lm3vc
github.com/pions/sctp v1.3.0/go.mod h1:GZTG/xApE7wdUFEQq2Rmzgxl/+YaB/L1k8xUl1D5bmo=
github.com/pions/sctp v1.3.1 h1:V5cRHMt+G9ufc44ITZvcEj7/nUyDukkB3Qr08TT29k4=
github.com/pions/sctp v1.3.1/go.mod h1:GZTG/xApE7wdUFEQq2Rmzgxl/+YaB/L1k8xUl1D5bmo=
github.com/pions/sdp v1.3.0 h1:HIv6ZvdzRPq+H4T8EV8K9pZ4EGnYOr14HFZ9Rksh6/0=
github.com/pions/sdp v1.3.0/go.mod h1:moNMmnVSlx8rBBb39U9t0Rdr7xvMlqiJjHlMESRad5k=
github.com/pions/sdp/v2 v2.0.0 h1:tWh8ehKPtXTaFYF12sBAHqYmhV36Q7YTmm3O6ycNa6M=
github.com/pions/sdp/v2 v2.0.0/go.mod h1:KGRBcHfpkgJXjrzKJz2wj/Jf1KWnsHdoIiqtayQ5QmE=
github.com/pions/srtp v1.0.3 h1:0rlg7yUHQblFA1e451mhx50IkA7+e48ja5K8mljyMYY=
github.com/pions/srtp v1.0.3/go.mod h1:egXe0STDyQDXLm7hjOMzuk7rkAhJ1SHOx+tTgtw/cQs=
github.com/pions/stun v0.2.0 h1:spIzpfkEg6HV+2iIo6qeOsAjtadZKzbXbrd2e9ZCCcs=
Expand Down
2 changes: 1 addition & 1 deletion icecandidate.go
Expand Up @@ -5,7 +5,7 @@ import (
"fmt"
"net"

"github.com/pions/sdp"
"github.com/pions/sdp/v2"
"github.com/pions/webrtc/pkg/ice"
)

Expand Down
2 changes: 1 addition & 1 deletion icecandidate_test.go
Expand Up @@ -4,7 +4,7 @@ import (
"net"
"testing"

"github.com/pions/sdp"
"github.com/pions/sdp/v2"
"github.com/pions/webrtc/pkg/ice"
"github.com/stretchr/testify/assert"
)
Expand Down
2 changes: 1 addition & 1 deletion mediaengine.go
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/pions/rtp"
"github.com/pions/rtp/codecs"
"github.com/pions/sdp"
"github.com/pions/sdp/v2"
)

// PayloadTypes for the default codecs
Expand Down
2 changes: 1 addition & 1 deletion mediaengine_test.go
Expand Up @@ -3,7 +3,7 @@ package webrtc
import (
"testing"

"github.com/pions/sdp"
"github.com/pions/sdp/v2"
"github.com/stretchr/testify/assert"
)

Expand Down
6 changes: 3 additions & 3 deletions peerconnection.go
Expand Up @@ -14,7 +14,7 @@ import (

"github.com/pions/rtcp"
"github.com/pions/rtp"
"github.com/pions/sdp"
"github.com/pions/sdp/v2"
"github.com/pions/webrtc/pkg/ice"
"github.com/pions/webrtc/pkg/logging"
"github.com/pions/webrtc/pkg/rtcerr"
Expand Down Expand Up @@ -1428,8 +1428,8 @@ func (pc *PeerConnection) addRTPMediaSection(d *sdp.SessionDescription, codecTyp
WithValueAttribute(sdp.AttrKeyConnectionSetup, dtlsRole.String()). // TODO: Support other connection types
WithValueAttribute(sdp.AttrKeyMID, midValue).
WithICECredentials(iceParams.UsernameFragment, iceParams.Password).
WithPropertyAttribute(sdp.AttrKeyRtcpMux). // TODO: support RTCP fallback
WithPropertyAttribute(sdp.AttrKeyRtcpRsize) // TODO: Support Reduced-Size RTCP?
WithPropertyAttribute(sdp.AttrKeyRTCPMux). // TODO: support RTCP fallback
WithPropertyAttribute(sdp.AttrKeyRTCPRsize) // TODO: Support Reduced-Size RTCP?

for _, codec := range pc.api.mediaEngine.getCodecsByKind(codecType) {
media.WithCodec(codec.PayloadType, codec.Name, codec.ClockRate, codec.Channels, codec.SDPFmtpLine)
Expand Down
2 changes: 1 addition & 1 deletion sessiondescription.go
@@ -1,7 +1,7 @@
package webrtc

import (
"github.com/pions/sdp"
"github.com/pions/sdp/v2"
)

// SessionDescription is used to expose local and remote session descriptions.
Expand Down

0 comments on commit 9cba54c

Please sign in to comment.