Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media: support sending MediaStreams with multiple tracks #16

Closed
3 tasks
Sean-Der opened this issue Jul 4, 2018 · 23 comments
Closed
3 tasks

media: support sending MediaStreams with multiple tracks #16

Sean-Der opened this issue Jul 4, 2018 · 23 comments
Labels
difficulty:easy

Comments

@Sean-Der
Copy link
Member

Sean-Der commented Jul 4, 2018 •
edited by backkem

Currently the media stream labels are hardcoded in the SDP offer and answer generation. The RTCPeerConnection.AddTrack should be extended to support adding media stream labels.

TODO

  • Add a variadic streams argument to the AddTrack method as specified in the RTP Media API
  • Store the media stream ids on the RTCTrack object as specified here
  • Add the media streams to the SDP offer and answer. Some of the required logic already exists. However, the stream label is currently hardcoded to the track label. The procedure is specified in the JSEP spec
@backkem
Copy link
Member

backkem commented Jul 8, 2018

For anyone interested in taking on this issue: Please check out #35. The purpose of the PR is to match the WebRTC API more closely and it should serve as a good basis to implement MediaStream support. However, MediaStream support itself has been ignored for now.

@backkem backkem changed the title Support sending MediaStreams with multiple tracks media: support sending MediaStreams with multiple tracks Jul 27, 2018
@gitcoinbot

This comment has been minimized.

Sign in to view
@backkem

This comment has been minimized.

Sign in to view
@notedit
Copy link
Contributor

notedit commented Jul 29, 2018

do we need implement unified-plan?

https://tools.ietf.org/html/draft-roach-mmusic-unified-plan-00

@backkem
Copy link
Member

backkem commented Jul 30, 2018

#54 has meanwhile been created to track unified-plan support.

@gitcoinbot

This comment has been minimized.

Sign in to view
@vukovinski

This comment has been minimized.

Sign in to view
@gitcoinbot

This comment has been minimized.

Sign in to view
@gitcoinbot

This comment has been minimized.

Sign in to view
@gitcoinbot

This comment has been minimized.

Sign in to view
@backkem
Copy link
Member

backkem commented Aug 31, 2018

Welcome @BR7braj. Looking forward to working with you. We're very active on the #pions channel of the golang slack if you have any questions.

@gitcoinbot

This comment has been minimized.

Sign in to view
8 similar comments
@gitcoinbot
Copy link

@BR7braj Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@BR7braj Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot

This comment has been minimized.

Sign in to view
@gitcoinbot
Copy link

@BR7braj Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@BR7braj Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@BR7braj Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@BR7braj Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@BR7braj Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Sean-Der
Copy link
Member Author

This was implemented.

(pc *RTCPeerConnection) NewRTCTrack allows you to pass MediaStream + track.

@gitcoinbot

This comment has been minimized.

Sign in to view
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled

The funding of 0.2 ETH (45.26 USD @ $226.28/ETH) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@notedit @Sean-Der @vukovinski @gitcoinbot @backkem