Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and enable QUIC tests #378

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Bump dependencies and enable QUIC tests #378

merged 1 commit into from
Jan 27, 2019

Conversation

Sean-Der
Copy link
Member

QUIC still leaks, but not causing other tests to flake

@coveralls
Copy link

coveralls commented Jan 27, 2019

Pull Request Test Coverage Report for Build 1898

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+1.5%) to 78.46%

Files with Coverage Reduction New Missed Lines %
pkg/ice/candidate.go 2 92.11%
internal/srtp/stream_srtcp.go 3 45.24%
internal/srtp/session_srtcp.go 5 74.12%
rtcpeerconnection.go 13 75.57%
Totals Coverage Status
Change from base Build 1877: 1.5%
Covered Lines: 5249
Relevant Lines: 6690

💛 - Coveralls

@Sean-Der Sean-Der force-pushed the quic-fix branch 4 times, most recently from afbab51 to ebc758c Compare January 27, 2019 10:36
QUIC still leaks, but not causing other tests to flake
@Sean-Der Sean-Der merged commit fc275ba into master Jan 27, 2019
@Sean-Der Sean-Der removed the review label Jan 27, 2019
@Sean-Der Sean-Der deleted the quic-fix branch January 28, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants