Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Use ICECandidateInit in AddICECandidate #426

Merged
merged 1 commit into from
Feb 21, 2019
Merged

API: Use ICECandidateInit in AddICECandidate #426

merged 1 commit into from
Feb 21, 2019

Conversation

backkem
Copy link
Member

@backkem backkem commented Feb 20, 2019

Resolves #358

@backkem backkem added the review label Feb 20, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2110

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.07%) to 79.052%
Changes Missing Coverage Covered Lines Changed/Added Lines %
peerconnection.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/ice/agent.go 2 84.98%
internal/mux/mux.go 4 92.5%
dtlstransport.go 4 75.14%
Totals Coverage Status
Change from base Build 2108: 0.07%
Covered Lines: 3951
Relevant Lines: 4998
💛 - Coveralls

@backkem backkem merged commit 0e619e2 into master Feb 21, 2019
@backkem backkem deleted the icecandidateinit branch February 21, 2019 06:09
@backkem backkem removed the review label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhawkins maxhawkins maxhawkins approved these changes

@mjmac mjmac mjmac approved these changes

@enobufs enobufs Awaiting requested review from enobufs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@backkem @coveralls @maxhawkins @mjmac