Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Encodings variable for ORTC #446

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Expose Encodings variable for ORTC #446

merged 1 commit into from
Feb 26, 2019

Conversation

kixelated
Copy link
Contributor

It's not possible to use a RTPReceiver without it.

@kixelated
Copy link
Contributor Author

I've been trying to figure out if the SSRC is actually required and I'm not sure. There doesn't seem to be a convenient way to get this information from the API like some of the other information required for signaling. Do you even need to signal the track SSRC?

c.receiver.Receive(webrtc.RTPReceiveParameters{
  Encodings: webrtc.RTPDecodingParameters{
    webrtc.RTPCodingParameters{SSRC: ssrc},
  },
})

@kixelated kixelated marked this pull request as ready for review February 26, 2019 06:57
@coveralls
Copy link

coveralls commented Feb 26, 2019

Pull Request Test Coverage Report for Build 2216

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 79.913%

Files with Coverage Reduction New Missed Lines %
dtlstransport.go 4 75.71%
peerconnection.go 9 74.74%
Totals Coverage Status
Change from base Build 2214: -0.2%
Covered Lines: 3859
Relevant Lines: 4829

💛 - Coveralls

It's not possible to use a RTPReceiver without it.
@Sean-Der Sean-Der merged commit 31b7044 into master Feb 26, 2019
@Sean-Der Sean-Der removed the review label Feb 26, 2019
@backkem backkem deleted the ortc-fix branch February 26, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants