Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for comments: java.io.{Throwable,Error,Exception}, clojure.lang.ExceptionInfo? #7

Open
piotr-yuxuan opened this issue Mar 21, 2022 · 1 comment
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@piotr-yuxuan
Copy link
Owner

piotr-yuxuan commented Mar 21, 2022

Currently closeable-map tries very hard to swallow everything, and as such uses the apex class java.io.Throwable in order to make completely sure errors truly are silent. This is opinionated. Is it a sane default? Why choose another better default? Perhaps this behaviour could be dynamically tuned according to the user's whishes?

Example:

This kind of change would break the API as a matter of course, and would trigger version 1.0.0.

@piotr-yuxuan piotr-yuxuan added help wanted Extra attention is needed question Further information is requested labels Mar 21, 2022
@piotr-yuxuan piotr-yuxuan self-assigned this Mar 21, 2022
@piotr-yuxuan
Copy link
Owner Author

However, user can still make use of ::closeable-map/ex-handler to handle exception happening when closing a map. That should be enough, but I'll leave open for some more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant