Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors with Ruby 3.1.2 #75

Closed
ghn opened this issue Apr 28, 2022 · 2 comments · Fixed by #74
Closed

Errors with Ruby 3.1.2 #75

ghn opened this issue Apr 28, 2022 · 2 comments · Fixed by #74
Assignees
@piotrmurach
Labels
bug

Comments

@ghn
Copy link

ghn commented Apr 28, 2022 •
edited

Describe the problem

Lots of warnings triggered when used with ruby 3.1.2

Steps to reproduce the problem

With ruby 3.1.2

bundle exec rspec

Actual behaviour

Error:

lib/finite_machine/observer.rb:22:in block in cleanup_callback_queue': undefined local variable or method callback_queue' for FiniteMachine::Observer:Class (NameError)

Expected behaviour

Specs pass without warnings

Describe your environment

  • OS version: osx 12
  • Ruby version: 3.1.2
  • FiniteMachine version: master
@ghn ghn added the bug label Apr 28, 2022
@ghn
Copy link
Author

ghn commented Apr 28, 2022

Related PR #74

@dup2
Copy link

dup2 commented May 1, 2023

Would be nice to fix this and release, it is not usable on ruby 3.1+ otherwise

@piotrmurach piotrmurach self-assigned this Aug 28, 2023
@piotrmurach piotrmurach linked a pull request Aug 28, 2023 that will close this issue
Fix defining object finalizer in Ruby 3.1 to reference a UUID string #74
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotrmurach piotrmurach

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix defining object finalizer in Ruby 3.1 to reference a UUID string
3 participants
@ghn @dup2 @piotrmurach