shell: fix handling of default values #19
Conversation
This fixes handling of 'empty input' by having Response detect an empty line input and feed it to Question#evaluate_response. Another code path I saw would have required to change all Necromancer converters to handle this special case ... did not seem appealing. However, the current Response class assumes that it is possible for read_input to distinguish between "no value provided" and "empty line as input". Since I did not see how it was possible, I removed that capability which ended up changing functionality: - read_multiple cannot input empty lines (since an empty line is now interpreted as no input) - read_email accepts empty email (but returns nil), which incidentally fixes default value handling for emails. If an email must be provided by the user, then call argument(:required).
|
I am more confident about this one. I know the tests do not pass (and that new tests need to be added), but since there are some caveats about the solution, I wanted to have your opinion before going forward with this. |
|
Agree with your reasoning behind the 'empty input'. The solution looks pragmatic and i'm happy with it. Would you mind finishing it with tests passing? |
Sure. Will do. |
shell: fix handling of default values
|
@peter-murach: sorry, I forgot about the tests, very busy months for me. |
|
You could have reminded me of them, you know ! |
|
No worries! You've done the hard work of fixing the issues and I needed to start extracting this out to another component called |
This fixes handling of 'empty input' by having Response detect an
empty line input and feed it to Question#evaluate_response. Another
code path I saw would have required to change all Necromancer
converters to handle this special case ... did not seem appealing.
However, the current Response class assumes that it is possible for
read_input to distinguish between "no value provided" and "empty
line as input". Since I did not see how it was possible, I removed
that capability which ended up changing functionality:
now interpreted as no input)
fixes default value handling for emails. If an email must be provided
by the user, then call argument(:required).